Missing pv.netcdf - #343
Open
Sharkyii wants to merge 9 commits into
Open
Conversation
Updated comments for clarity and improved metadata handling.
Contributor
Author
|
@peterdudfield could you review this when you have time? |
Contributor
Author
|
@peterdudfield this is ready to merge? |
Contributor
|
Hye, Would you be able to get unit tests working? Or is that something else? |
Contributor
Author
|
Test: Root error: Where it happens: The chain:
@peterdudfield have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the evaluation script which was broken due to changes in the Hugging Face dataset structure. The dataset no longer provides a single
pv.netcdffile but instead uses partitioned Parquet files organized by year and month (5_minutely/year=YYYY/month=MM/data.parquet).Changes:
get_pv_truth()inquartz_solar_forecast/eval/pv.pyto download and process monthly Parquet files instead of a single NetCDF filess_id→pv_id,datetime_GMT→timestamp,generation_Wh→generation_wh).gitignoreto exclude temporary directoriesDependencies:
pyarrowfor Parquet file supportFixes #283
How Has This Been Tested?
Tested with the full evaluation pipeline